docs(experimentation): document PostgreSQL warehouses - #8873

Actionable comments posted: 3

Nitpick comments: 1

frontend/web/components/pages/environment-settings/tabs/warehouse-tab/__tests__/postgresSetupSqlDocs.test.ts: 1

5-5: Trivial · Functional Correctness · Quick win

Normalise each line separately in the docs parity test.

normalise replaces every line break with a space. In the docs fence, a -- comment can then run into the next statement. If a future edit moves CREATE USER onto the comment line, the normalised text still matches the dashboard SQL, so the test passes. PostgreSQL does not run the joined CREATE USER, and the following GRANT statements fail because the role does not exist. The current guide is correct, so this affects only future edits to the docs.

Normalise each line separately to keep the line boundaries:

Suggested fix

-const normalise = (sql: string) => sql.replace(/\s+/g, ' ').trim()
+const normalise = (sql: string) =>
+  sql
+    .split('\n')
+    .map((line) => line.replace(/\s+/g, ' ').trim())
+    .filter(Boolean)
+    .join('\n')

Review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: e8cffcbc-124d-455d-98d0-45909dde738b

Commits

Reviewing files that changed from the base of the PR and between af5c88f and 6cc79f8.

Files ignored due to path filters: 4

• docs/static/img/experimentation/warehouse-flagsmith-database-connected.png is excluded by !**/*.png
• docs/static/img/experimentation/warehouse-flagsmith-database.png is excluded by !**/*.png
• docs/static/img/experimentation/warehouse-postgres-connected.png is excluded by !**/*.png
• docs/static/img/experimentation/warehouse-postgres-form.png is excluded by !**/*.png

Files selected for processing: 13

• docs/docs/deployment-self-hosting/core-configuration/environment-variables.md
• docs/docs/deployment-self-hosting/hosting-guides/kubernetes-openshift.md
• docs/docs/experimentation/connect-a-warehouse.md
• docs/docs/experimentation/connect-databricks.md
• docs/docs/experimentation/connect-postgresql.md
• docs/docs/experimentation/run-an-experiment.mdx
• docs/docs/experimentation/self-hosting.md
• frontend/web/components/pages/environment-settings/tabs/warehouse-tab/WarehouseSetup.tsx
• frontend/web/components/pages/environment-settings/tabs/warehouse-tab/__tests__/clickhouseSetupSql.test.ts
• frontend/web/components/pages/environment-settings/tabs/warehouse-tab/__tests__/postgresSetupSql.test.ts
• frontend/web/components/pages/environment-settings/tabs/warehouse-tab/__tests__/postgresSetupSqlDocs.test.ts
• frontend/web/components/pages/environment-settings/tabs/warehouse-tab/clickhouseSetupSql.ts
• frontend/web/components/pages/environment-settings/tabs/warehouse-tab/postgresSetupSql.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.